Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable "-HV 2021" option for DXC #6445

Merged

Conversation

jkwak-work
Copy link
Collaborator

Closes #6442

@jkwak-work jkwak-work added the pr: non-breaking PRs without breaking changes label Feb 24, 2025
@jkwak-work jkwak-work self-assigned this Feb 24, 2025
@jkwak-work jkwak-work requested a review from a team as a code owner February 24, 2025 19:45
csyonghe
csyonghe previously approved these changes Feb 24, 2025
@jkwak-work
Copy link
Collaborator Author

This PR cannot be merged until I resolve the duplicated witness table problem.
CI error shows the same problem as when I tried to upgrade DXC 1.7 to DXC 1.9.

    dxc 1.7: C:/actions-runner/_work/slang/slang/FalcorBin/build/windows-vs2022/bin/Release/shaders/Utils/Math/ShadingFrame.slang(116): error :  no matching function for call to 's_fwd_d_dot_0'
    dxc 1.7: note :     DiffPair_6 _S915 = s_fwd_d_dot_0(_S913, _S914);
    dxc 1.7: note :                        ^~~~~~~~~~~~~
    dxc 1.7: C:/actions-runner/_work/slang/slang/FalcorBin/build/windows-vs2022/bin/Release/shaders/DiffRendering/DiffSceneQuery.slang(239): error :  candidate function not viable: no known conversion from 'DiffPair_4' to 'DiffPair_10' for 1st argument
    dxc 1.7: note : DiffPair_6 s_fwd_d_dot_0(DiffPair_10 dpdpx_3, DiffPair_10 dpdpy_0)
    dxc 1.7: note :            ^
    dxc 1.7: C:/actions-runner/_work/slang/slang/FalcorBin/build/windows-vs2022/bin/Release/shaders/Utils/Math/ShadingFrame.slang(117): error :  no matching function for call to 's_fwd_d_cross_0'
    dxc 1.7: note :     DiffPair_10 _S927 = s_fwd_d_cross_0(_S914, _S926);
    dxc 1.7: note :                         ^~~~~~~~~~~~~~~

@jkwak-work jkwak-work force-pushed the fix/always_use_dxc_option_hv_2021 branch from 00cf9d6 to b1008dc Compare April 2, 2025 10:28
@jkwak-work jkwak-work enabled auto-merge (squash) April 2, 2025 10:29
@jkwak-work jkwak-work merged commit e44479c into shader-slang:master Apr 2, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slang 2025.5.2 no longer supports select when targetting HLSL with dxc 1.7
2 participants