Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use reusable action for CI #45

Conversation

martencassel
Copy link
Contributor

@martencassel martencassel commented Feb 18, 2025

Implement smart_proxy_plugin action in GitHub CI

@ekohl
Copy link
Member

ekohl commented Feb 18, 2025

If you want to cleanly separate all your changes (and I appreciate you're making an effort), this is where I would expect more changes to make CI green. In particular, the reusable action verifies the gemspec in strict mode so cleaning up the gemspec is IMHO something that should happen before this could be merged.

@martencassel martencassel force-pushed the use-reusable-action-for-testing branch from c7eacdb to 7a0d472 Compare February 18, 2025 21:14
@martencassel martencassel marked this pull request as draft February 18, 2025 21:15
@martencassel martencassel force-pushed the use-reusable-action-for-testing branch 3 times, most recently from 1592624 to 1a9ed85 Compare February 18, 2025 22:02
@martencassel martencassel changed the title Use reusable action to do Smart Proxy testing Utilize reusable smart_proxy_plugin action in GitHub CI workflow Feb 18, 2025
@martencassel martencassel changed the title Utilize reusable smart_proxy_plugin action in GitHub CI workflow Use reusable action for CI Feb 18, 2025
@martencassel martencassel force-pushed the use-reusable-action-for-testing branch from 1a9ed85 to 51bf382 Compare February 18, 2025 22:04
@martencassel martencassel marked this pull request as ready for review February 18, 2025 22:05
@martencassel martencassel force-pushed the use-reusable-action-for-testing branch 3 times, most recently from f543132 to 7599af5 Compare February 18, 2025 22:15
- Implement smart_proxy_plugin action in GitHub CI
@martencassel martencassel force-pushed the use-reusable-action-for-testing branch from 7599af5 to 0a33b29 Compare February 18, 2025 22:17
@martencassel martencassel deleted the use-reusable-action-for-testing branch February 19, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants