generic: fix several gtest issues #2159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform:gpu-generic
t4c1
approved these changes
Oct 10, 2024
|
The failing CI check is in a file not added by this PR. |
t4c1
reviewed
Oct 14, 2024
mgouicem
reviewed
Oct 14, 2024
ShanoToni
approved these changes
Oct 14, 2024
sgeor255
force-pushed
the
svet/gtest-fixes
branch
2 times, most recently
from
7ece4ff to
bd5d8b7
Compare
sgeor255
force-pushed
the
svet/gtest-fixes
branch
2 times, most recently
from
ecd48b5 to
26d2f8e
Compare
|
make test |
sgeor255
force-pushed
the
svet/gtest-fixes
branch
from
26d2f8e to
ddf135a
Compare
|
make test |
sgeor255
force-pushed
the
svet/gtest-fixes
branch
from
ddf135a to
caddac1
Compare
sgeor255
force-pushed
the
svet/gtest-fixes
branch
from
caddac1 to
9e8b62f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes several gtest issues on generic vendor:
NDR.LocalSize[0]==0assertion was being thrown due to problems with 0-dim input/outputs not handled correctlyinit()There are some convolution backward data & deconvolution tests that are still failing which will be fixed in a separate PR (as the issue doesn't seem to be caused by missing skips)