Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: clang-tidy: fix checkout procedure #2911

Merged
merged 4 commits into from
Mar 19, 2025
Merged

ci: clang-tidy: fix checkout procedure #2911

merged 4 commits into from
Mar 19, 2025

Conversation

hmaciak
Copy link
Contributor

@hmaciak hmaciak commented Mar 18, 2025 •
edited
Loading

This PR provides fix for clang-tidy checkout procedure.

@hmaciak hmaciak requested a review from a team as a code owner March 18, 2025 16:23
@hmaciak hmaciak marked this pull request as draft March 18, 2025 16:23
@github-actions github-actions bot added the devops Github automation label Mar 18, 2025
@github-actions github-actions bot added the platform:cpu-x64 Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64 label Mar 18, 2025
@github-actions github-actions bot removed the platform:cpu-x64 Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64 label Mar 18, 2025
@hmaciak
Copy link
Contributor Author

hmaciak commented Mar 18, 2025 •
edited
Loading

This should fix problem in old PR's. I tested this approach here (merge hmaciak/test_pr_merge -> hmaciak/fix_clang_checkout) https://github.com/uxlfoundation/oneDNN/actions/runs/13928783179/job/38980278198?pr=2912
As you can see 1f2ed23
I added here changes in script and some cpp files and tried to merge hmaciak/test_pr_merge to this branch.

Result:
-> script is from this branch
-> checked files with changes only in hmaciak/test_pr_merge

@hmaciak hmaciak marked this pull request as ready for review March 18, 2025 16:54
@vpirogov
Copy link
Contributor

Pls squash the commits.

Sqvid
Sqvid approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@Sqvid Sqvid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hmaciak hmaciak merged commit 8d80048 into main Mar 19, 2025
12 of 13 checks passed
@hmaciak hmaciak deleted the hmaciak/fix_clang_checkout branch March 19, 2025 08:46
@vpirogov vpirogov mentioned this pull request Mar 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpirogov vpirogov vpirogov approved these changes

@Sqvid Sqvid Sqvid approved these changes

@theComputeKid theComputeKid Awaiting requested review from theComputeKid

Assignees
No one assigned
Labels
devops Github automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hmaciak @vpirogov @Sqvid