Another bucket of fixes (and future bugs...) #2917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform:cpu-x64
|
make test |
dzarukin
force-pushed
the
dzarukin/allow_int4_odd
branch
from
5f0373c to
a14aff9
Compare
|
make test |
dzarukin
force-pushed
the
dzarukin/allow_int4_odd
branch
2 times, most recently
from
b34fab9 to
2e2c013
Compare
|
make test |
dzarukin
force-pushed
the
dzarukin/allow_int4_odd
branch
3 times, most recently
from
8e14b33 to
f4d86c8
Compare
|
make test |
dzarukin
force-pushed
the
dzarukin/allow_int4_odd
branch
from
f4d86c8 to
8e04316
Compare
|
make test |
mgouicem
reviewed
Mar 20, 2025
avmanerikar
reviewed
Mar 20, 2025
… on it Case with different mask is not supported if only both scales were specified.
Temporary "const char *" objects can disappear while getting to the parser internals. Moving strings to parse into a permanent container solves the problem.
dzarukin
force-pushed
the
dzarukin/allow_int4_odd
branch
from
8e04316 to
608baa3
Compare
|
make test |
avmanerikar
approved these changes
Mar 21, 2025
ankalinin
approved these changes
Mar 24, 2025
vpirogov
force-pushed
the
dzarukin/allow_int4_odd
branch
from
608baa3 to
f933c1e
Compare
vpirogov
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MFDNN-13351 - improve filling for matmul so that benchdnn doesn't report false-positives with relatively big zero-point values.
MFDNN-13377 - Update benchdnn and the library to restrict int4 buffers for byte-alignment only on the most dense dimension.
MFDNN-13360 - Fixup of previous change reducing the scratchpad space - the execute part was misaligned with the updated logic.
MFDNN-13368 - Updated benchdnn filling for reorder to avoid underflow in case of s32 validation with zero-points.
MFDNN-13376 - The product of refactor + a victim of a bug in benchdnn which didn't report cases becoming unimplemented properly. Reporting was fixed, case started returning unimplemented as expected. Unimplemented case was fixed in jit_uni_reorder, and also verbose messages were added.
MFDNN-11868 - Use a string object to carry the content for parsing as it sometimes somehow can be destroyed.