feat(ci): publish ARM macOS builds #22140

pront · 2025-01-07T20:19:23Z

Summary

Follow up to #22134.
We now have access to a GitHub runner which can produce ARM executables.

Change Type

Bug fix
New feature
Non-functional (chore, refactoring, docs)
Performance

Is this a breaking change?

Yes
No

How did you test this PR?

Does this PR include user facing changes?

Yes. Please add a changelog fragment based on our guidelines.
No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

Please read our Vector contributor resources.
If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

Ref:

datadog-vectordotdev · 2025-01-07T20:33:33Z

Datadog Report

Branch report: pront/feat-arm-macos-builds
Commit report: 1a83c47
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.43s Total Time

jszwedko

Big 👍 to adding arm Mac builds. People have been asking for these for a while. I think you can run the "Custom Build" workflow (supports workflow_dispatch) with this branch to test before merging.

Additionally, we'll need to update:

The homebrew formula to support both architectures
Maybe distribution/install.sh to choose the correct architecture?
The website to include a link to the arm artifacts for new releases

We could do that after this is merged though.

.github/workflows/publish.yml

pront · 2025-01-07T21:14:09Z

Additionally, we'll need to update:

The homebrew formula to support both architectures

Maybe distribution/install.sh to choose the correct architecture?

The website to include a link to the arm artifacts for new releases

We could do that after this is merged though.

Awesome, I will update these tomorrow.

.github/workflows/publish.yml

…oring)

pront · 2025-01-08T16:51:11Z

.github/workflows/publish.yml

@@ -605,6 +630,11 @@ jobs:
        with:
          name: vector-${{ env.VECTOR_VERSION }}-x86_64-apple-darwin
          path: target/artifacts
+      - name: Download staged package artifacts (arm64-apple-darwin)


Note: All these jobs are repetitive. They would benefit from a download-artifacts job. But that is too big of change for this PR. I will follow-up in another PR.

jszwedko

Nice! Looks good to me now assuming the Custom Build workflow executes successfully. Could we run than on this branch before merging?

jszwedko · 2025-01-08T18:17:45Z

distribution/install.sh

        x86_64-*linux*-gnu)
            _archive_arch="x86_64-unknown-linux-gnu"
            ;;
        x86_64-*linux*-musl)
            _archive_arch="x86_64-unknown-linux-musl"
            ;;
-        aarch64-apple-darwin)


pront · 2025-01-08T18:23:32Z

Nice! Looks good to me now assuming the Custom Build workflow executes successfully. Could we run than on this branch before merging?

Kicked off here: https://github.com/vectordotdev/vector/actions/runs/12676670228

.github/workflows/publish.yml

Co-authored-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

.github/workflows/publish.yml

Co-authored-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

pront · 2025-01-08T19:10:12Z

Note: Per our discussion, we will do the homebrew changes after we publish the first ARM release.

jszwedko · 2025-01-08T19:29:30Z

website/cue/reference/administration/downloads.cue

+				  {
+						target: "arm64-apple-darwin-tar-gz"
+						arch:   "ARM64"
+						extra:  "apple-darwin"
+					}


This will 404 on all existing releases. I'm wondering if we need to add some sort of optional version specifier here. Like: version: ">= 0.44.0" that could be used when rendering the download page to determine if a particular platform should be rendered. This could be follow-up work to this PR (in which case we should just delete this new entry for now to avoid the user confusion from 404s).

Agreed. Will follow-up in another PR.

cswatt

approved for docs, seems other issues persist

jszwedko

🎉

* feat(ci): publish ARM macOS builds * typo * rename build job to build-apple-darwin-packages * add comments and link to large runners * add pre-condition for early exit * simplify verification step * small tweaks * add arm64-apple-darwin branches to various jobs (this begs for refactoring) * update distribution/install.sh * Update .github/workflows/publish.yml Co-authored-by: Jesse Szwedko <jesse.szwedko@datadoghq.com> * Update .github/workflows/publish.yml Co-authored-by: Jesse Szwedko <jesse.szwedko@datadoghq.com> --------- Co-authored-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

feat(ci): publish ARM macOS builds

b824c3b

pront requested a review from a team as a code owner January 7, 2025 20:19

pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jan 7, 2025

typo

d9c2d2d

pront requested a review from jszwedko January 7, 2025 20:25

jszwedko reviewed Jan 7, 2025

View reviewed changes

.github/workflows/publish.yml Outdated Show resolved Hide resolved

.github/workflows/publish.yml Outdated Show resolved Hide resolved

.github/workflows/publish.yml Outdated Show resolved Hide resolved

pront added 3 commits January 7, 2025 16:01

rename build job to build-apple-darwin-packages

3c2d240

add comments and link to large runners

31a6b89

add pre-condition for early exit

20b6a0e

jszwedko reviewed Jan 7, 2025

View reviewed changes

.github/workflows/publish.yml Show resolved Hide resolved

.github/workflows/publish.yml Show resolved Hide resolved

pront added 4 commits January 8, 2025 11:17

simplify verification step

882c249

Merge remote-tracking branch 'origin' into pront/feat-arm-macos-builds

1fa40b2

small tweaks

c9e2d87

add arm64-apple-darwin branches to various jobs (this begs for refact…

4f3f180

…oring)

pront commented Jan 8, 2025

View reviewed changes

update distribution/install.sh

4d8d88d

github-actions bot added the domain: releasing Anything related to releasing Vector label Jan 8, 2025

jszwedko reviewed Jan 8, 2025

View reviewed changes

.github/workflows/publish.yml Outdated Show resolved Hide resolved

Update .github/workflows/publish.yml

64f8b4a

Co-authored-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

jszwedko reviewed Jan 8, 2025

View reviewed changes

.github/workflows/publish.yml Outdated Show resolved Hide resolved

Update .github/workflows/publish.yml

dce48a4

Co-authored-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

pront requested review from a team as code owners January 8, 2025 19:20

github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label Jan 8, 2025

jszwedko reviewed Jan 8, 2025

View reviewed changes

cswatt approved these changes Jan 8, 2025

View reviewed changes

pront force-pushed the pront/feat-arm-macos-builds branch from 676b724 to dce48a4 Compare January 8, 2025 20:04

github-actions bot removed the domain: external docs Anything related to Vector's external, public documentation label Jan 8, 2025

pront enabled auto-merge January 8, 2025 20:06

pront disabled auto-merge January 8, 2025 20:13

jszwedko approved these changes Jan 8, 2025

View reviewed changes

pront added this pull request to the merge queue Jan 8, 2025

Merged via the queue into master with commit 0720345 Jan 8, 2025
108 checks passed

pront deleted the pront/feat-arm-macos-builds branch January 8, 2025 22:37

pront mentioned this pull request Jan 9, 2025

chore(ci): major publish.yml refactoring #22151

Closed

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ci): publish ARM macOS builds #22140

feat(ci): publish ARM macOS builds #22140

pront commented Jan 7, 2025 •

edited

Loading

datadog-vectordotdev bot commented Jan 7, 2025 •

edited

Loading

jszwedko left a comment

pront commented Jan 7, 2025

pront Jan 8, 2025 •

edited

Loading

jszwedko left a comment

jszwedko Jan 8, 2025

pront commented Jan 8, 2025

pront commented Jan 8, 2025

jszwedko Jan 8, 2025

pront Jan 8, 2025

cswatt left a comment

jszwedko left a comment

feat(ci): publish ARM macOS builds #22140

feat(ci): publish ARM macOS builds #22140

Conversation

pront commented Jan 7, 2025 • edited Loading

Summary

Change Type

Is this a breaking change?

How did you test this PR?

Does this PR include user facing changes?

Checklist

References

datadog-vectordotdev bot commented Jan 7, 2025 • edited Loading

Datadog Report

jszwedko left a comment

Choose a reason for hiding this comment

pront commented Jan 7, 2025

pront Jan 8, 2025 • edited Loading

Choose a reason for hiding this comment

jszwedko left a comment

Choose a reason for hiding this comment

jszwedko Jan 8, 2025

Choose a reason for hiding this comment

pront commented Jan 8, 2025

pront commented Jan 8, 2025

jszwedko Jan 8, 2025

Choose a reason for hiding this comment

pront Jan 8, 2025

Choose a reason for hiding this comment

cswatt left a comment

Choose a reason for hiding this comment

jszwedko left a comment

Choose a reason for hiding this comment

pront commented Jan 7, 2025 •

edited

Loading

datadog-vectordotdev bot commented Jan 7, 2025 •

edited

Loading

pront Jan 8, 2025 •

edited

Loading