Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud_function: solana uses acct instead of txhash #201

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

panoel
Copy link
Contributor

@panoel panoel commented Feb 7, 2024

No description provided.

bingyuyap
bingyuyap previously approved these changes Feb 7, 2024
Copy link
Contributor

@bingyuyap bingyuyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Added some comments

bingyuyap
bingyuyap previously approved these changes Feb 7, 2024
Copy link
Contributor

@bingyuyap bingyuyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a small nit

bingyuyap
bingyuyap previously approved these changes Feb 8, 2024
bingyuyap
bingyuyap previously approved these changes Feb 8, 2024
Copy link
Contributor

@bingyuyap bingyuyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bingyuyap
bingyuyap previously approved these changes Feb 27, 2024
Copy link
Contributor

@bingyuyap bingyuyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should wait for @evan-gray's review for the Solana just to be safe

@panoel panoel force-pushed the fix_solana_reobservations branch from 126f7ee to a2ab033 Compare March 5, 2024 19:04
@panoel panoel requested a review from bingyuyap March 5, 2024 19:05
@panoel panoel force-pushed the fix_solana_reobservations branch from a2ab033 to 5655393 Compare March 11, 2024 18:26
@panoel panoel merged commit 2878541 into main Mar 11, 2024
3 checks passed
@panoel panoel deleted the fix_solana_reobservations branch March 11, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants