Support for changing CWD + respecting source path #7
Conversation
This adds support for changing the current working directory via options, and uses the source path (relative to the cwd) instead of just the filename when determining the destination path.
|
Hi guys, after @ebaranov's prod, I pulled down this merge request, but notice that it causes tests to fail. For some reason the grunt test --force command which was used to test the pull request on Travis (https://travis-ci.org/yoniholmes/grunt-text-replace/builds/6015643) didn't fail, but if you review the logs and test locally, you can see that a bunch of test have stopped working. If anyone is keen for this feature, please amend until the tests work. I'll also leave a comment on the modified files on naming conventions. Many thanks, Jonathan |
| var dest = settings.dest; | ||
| var cwd = settings.cwd; |
There was a problem hiding this comment.
Hi there. Thanks again for submitting your pull request. This review is coming quite late, but was spurred on by a recent request. A minor point, but for legibility reasons I'd opt for 'currentWorkingDirectory' instead of 'cwd'. As we 'previousWorkingDirectory'. Cheers & many thanks, Jonathan
This adds support for changing the current working directory via
options, and uses the source path (relative to the cwd) instead of just
the filename when determining the destination path.