Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable NETC support for i.MX95 EKV M7 #81113

Merged
merged 10 commits into from
Mar 25, 2025
Merged

Enable NETC support for i.MX95 EKV M7 #81113

merged 10 commits into from
Mar 25, 2025

Conversation

yangbolu1991
Copy link
Contributor

This PR is to enable NETC support for i.MX95 EKV M7.
There are dependencies of this PR.

Current PR already cherry-pick scmi changes and updated west.yml to address the dependency for CI.
And will drop them once they are merged.

Thanks.

@zephyrbot
Copy link
Collaborator

zephyrbot commented Nov 8, 2024 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@9dc7449 zephyrproject-rtos/hal_nxp@8375b98 zephyrproject-rtos/hal_nxp@9dc74490..8375b982

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Nov 8, 2024
@LaurentiuM1234 LaurentiuM1234 mentioned this pull request Dec 2, 2024
Merged
@yangbolu1991
Copy link
Contributor Author

Updated to v2. Changes,

  • Rebased on latest scmi patches. And addressed west.yml conflict.

Thanks.

@decsny decsny requested review from LaurentiuM1234 and removed request for yvanderv December 17, 2024 17:33
@yangbolu1991
Copy link
Contributor Author

Rebased to try CI again.
Thanks.

@yangbolu1991
Copy link
Contributor Author

Rebased, thanks.

@mmahadevan108
Copy link
Collaborator

@JiafeiPan , can you help review this PR.

JiafeiPan
JiafeiPan reviewed Mar 21, 2025
View reviewed changes
boards/nxp/imx95_evk/imx95_evk_mimx9596_m7.dts Outdated
pinctrl-names = "default";
phy-handle = <&phy0>;
phy-connection-type = "rgmii";
status = "okay";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to disable all related nodes by default in board dts, and enable them in dts overlay, then can use "-DEXTRA_DTC_OVERLAY_FILE=enet1.overlay" if needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jiafei. Will do that.

@yangbolu1991
Copy link
Contributor Author

Updated to v7. Changes include,

  • Created overlay file for enetc psi0 instead, and doc it.

Thanks.

JiafeiPan
JiafeiPan reviewed Mar 24, 2025
View reviewed changes
boards/nxp/imx95_evk/enetc_psi0.overlay Outdated
@@ -0,0 +1,17 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may have the other overlay for other features, I suggest to put all of them in "dts" sub-directory just like what the other platforms are using.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, updated.
Thanks.

boards/nxp/imx95_evk/imx95_evk_mimx9596_m7.dts
@@ -23,6 +23,24 @@
};
};

&emdio {
pinctrl-0 = <&emdio_default>;
pinctrl-names = "default";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know these nodes are disabled in soc dts, but I prefer to put explict "disabled" status for these nodes to make it more readable for the user to know it is disabled currently.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, updated.
Thanks.

@yangbolu1991
Copy link
Contributor Author

Updated to v8. Changes include,

  • moved overlay file to dts/ directory.
  • put explicit disabled status in dts.

Thanks.

@yangbolu1991 @mmahadevan108
west.yml: update hal_nxp to support i.MX95 NETC
7a74963 
Updated hal_nxp to support i.MX95 NETC.

Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
@yangbolu1991 @mmahadevan108
drivers: ethernet: eth_nxp_imx_netc: get irq from dts node
56cddb9 
Added support to get irq from dts node, because some platforms may
use multi-level interrupts, and the system INTID may not be connected
directly to interrupt controller.

Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
@yangbolu1991 @mmahadevan108
dts: arm: nxp_imx95_m7: add power domain node and definitions
8f35635 
Added power domain node and i.MX95 power domain header file.

Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
@yangbolu1991 @mmahadevan108
dts: arm: nxp_imx95_m7: add NETC node and IRQSTEER node
87f3904 
Added NETC device tree node, and IRQSTEER node.

Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
@yangbolu1991 @mmahadevan108
soc: nxp: imx95: enable multi-level interrupts for m7
c0a71cf 
Enabled multi-level interrupts for m7 since IRQSTEER is used.

Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
@yangbolu1991 @mmahadevan108
tests: arm: exclude i.mx95 m7 for some interrupt tests
a99e87c 
i.MX95 M7 is using multi-level interrupts with custom
interrupt handling. So, arm_custom_interrupt and
arm_irq_vector_table tests should exclude it.

Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
@yangbolu1991 @mmahadevan108
soc: nxp: imx95: support M7 soc init for NETC
882e257 
Added support for soc init for NETC.

Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
@yangbolu1991 @mmahadevan108
boards: nxp: imx95_evk: add board init for NETC
8d94680 
Added board init for NETC.

Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
@yangbolu1991 @mmahadevan108
boards: nxp: imx95_evk: enable NETC PSI0 for M7
e88f17b 
Enabled NETC PSI0 for M7.

Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
@yangbolu1991 @mmahadevan108
boards: nxp: imx95_evk: update doc and yml for NETC support on M7
1d44cf2 
Updated imx95_evk doc and yml for NETC support on M7.

Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
@kartben kartben merged commit 660035d into zephyrproject-rtos:main Mar 25, 2025
31 checks passed
@mmahadevan108 mmahadevan108 deleted the feature/imx95_netc branch March 25, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahadevan108 mmahadevan108 mmahadevan108 approved these changes

@JiafeiPan JiafeiPan JiafeiPan approved these changes

@dleach02 dleach02 dleach02 approved these changes

@ceolin ceolin Awaiting requested review from ceolin

@danieldegrasse danieldegrasse Awaiting requested review from danieldegrasse

@dbaluta dbaluta Awaiting requested review from dbaluta

@decsny decsny Awaiting requested review from decsny

@iuliana-prodan iuliana-prodan Awaiting requested review from iuliana-prodan

@lmajewski lmajewski Awaiting requested review from lmajewski

@manuargue manuargue Awaiting requested review from manuargue

@MarkWangChinese MarkWangChinese Awaiting requested review from MarkWangChinese

@nashif nashif Awaiting requested review from nashif

@pdgendt pdgendt Awaiting requested review from pdgendt

@teburd teburd Awaiting requested review from teburd

@LaurentiuM1234 LaurentiuM1234 Awaiting requested review from LaurentiuM1234

Assignees

@mmahadevan108 mmahadevan108

@dleach02 dleach02

Labels
area: Architectures area: ARM ARM (32-bit) Architecture area: Ethernet area: Interrupt Controller area: Power Management manifest manifest-hal_nxp platform: NXP Drivers NXP Semiconductors, drivers platform: NXP MPU
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@yangbolu1991 @zephyrbot @mmahadevan108 @dleach02 @JiafeiPan @kartben @fabiobaltieri