Bluetooth: conn: Make bt_conn_lookup_addr_br() public #87186
Conversation
zephyrbot
added
area: Bluetooth Host
zephyrbot
requested review from
alwa-nordic,
cvinayak,
fabiobaltieri,
hermabe,
jhedberg,
kartben,
rugeGerritsen,
sjanc,
Thalley and
theob-pro
There was a problem hiding this comment.
Please fix the spelling in the commit message.
Bluetooth: conn: Public the function bt_conn_lookup_addr_br
"Public" cannot be used as a verb. "Make bt_conn_lookup_addr_br() public" would be better.
Move the deceleration of function
bt_conn_lookup_addr_brfrom
conn_internal.htoconn.h.
"Move the declaration of bt_conn_lookup_addr_br()"
or
"Move the declaration of the function bt_conn_lookup_addr_br() ..."
lylezhu2012
force-pushed
the
br_conn_public_bt_conn_lookup_addr_br
branch
from
db73f98 to
eb44983
Compare
lylezhu2012
changed the title
Updated. Thanks a lot. |
Thanks, however you still have "deceleration" misspelled (should be "declaration") |
lylezhu2012
force-pushed
the
br_conn_public_bt_conn_lookup_addr_br
branch
from
eb44983 to
cab15f1
Compare
Thanks. Updated it. |
lylezhu2012
force-pushed
the
br_conn_public_bt_conn_lookup_addr_br
branch
from
cab15f1 to
c1ee921
Compare
lylezhu2012
force-pushed
the
br_conn_public_bt_conn_lookup_addr_br
branch
from
c1ee921 to
4a02cbb
Compare
lylezhu2012
force-pushed
the
br_conn_public_bt_conn_lookup_addr_br
branch
from
4a02cbb to
df74211
Compare
lylezhu2012
force-pushed
the
br_conn_public_bt_conn_lookup_addr_br
branch
from
df74211 to
36bd4d5
Compare
| * | ||
| * @return Connection object or NULL if not found. | ||
| */ | ||
| struct bt_conn *bt_conn_lookup_addr_br(const bt_addr_t *peer); |
There was a problem hiding this comment.
Kind of odd that we have both bt_le_<something> and bt_<something>_le naming in our API.
Generally it would make sense to have bt_le_<something> and bt_br_<something> (or bt_classic if we wanted to follow the naming scheme in files and Kconfig...), but since the LE version of this funcion is bt_conn_lookup_addr_le, then I guess it makes sense to continue with that.
As mentioned in my other review, I do think it makes equally / more sense to just use bt_conn_get_info as that already contains this functionality.
There was a problem hiding this comment.
However, for purposes that only want to obtain the peer address, calling bt_conn_get_info is too complicated.
Because within the function bt_conn_get_info, not only are memory read and write operations performed, but HCI access is also introduced.
Obviously, this function is not always easy to use.
For LE, I speculate that this may also be the reason for the existence of bt_conn_lookup_ addr_le.
Move the declaration of the function `bt_conn_lookup_addr_br()` from `conn_internal.h` to `conn.h`. Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>
lylezhu2012
force-pushed
the
br_conn_public_bt_conn_lookup_addr_br
branch
from
36bd4d5 to
8e5503f
Compare
Move the declaration of the function
bt_conn_lookup_addr_br()fromconn_internal.htoconn.h.