Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth: conn: Make bt_conn_lookup_addr_br() public #87186

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Bluetooth: conn: Make bt_conn_lookup_addr_br() public #87186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/releases/release-notes-4.2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ New APIs and options
* :c:func:`bt_le_get_local_features`
* :c:func:`bt_le_bond_exists`
* :c:func:`bt_br_bond_exists`
* :c:func:`bt_conn_lookup_addr_br`

* Display

Expand Down
13 changes: 13 additions & 0 deletions include/zephyr/bluetooth/conn.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2618,6 +2618,19 @@ struct bt_br_conn_param {
struct bt_conn *bt_conn_create_br(const bt_addr_t *peer,
const struct bt_br_conn_param *param);

/** @brief Look up an existing BR connection by address.
*
* Look up an existing BR connection based on the remote address.
*
* The caller gets a new reference to the connection object which must be
* released with bt_conn_unref() once done using the object.
*
* @param peer Remote address.
*
* @return Connection object or NULL if not found.
*/
struct bt_conn *bt_conn_lookup_addr_br(const bt_addr_t *peer);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of odd that we have both bt_le_<something> and bt_<something>_le naming in our API.

Generally it would make sense to have bt_le_<something> and bt_br_<something> (or bt_classic if we wanted to follow the naming scheme in files and Kconfig...), but since the LE version of this funcion is bt_conn_lookup_addr_le, then I guess it makes sense to continue with that.

As mentioned in my other review, I do think it makes equally / more sense to just use bt_conn_get_info as that already contains this functionality.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, for purposes that only want to obtain the peer address, calling bt_conn_get_info is too complicated.

Because within the function bt_conn_get_info, not only are memory read and write operations performed, but HCI access is also introduced.

Obviously, this function is not always easy to use.

For LE, I speculate that this may also be the reason for the existence of bt_conn_lookup_ addr_le.


#ifdef __cplusplus
}
#endif
Expand Down
5 changes: 5 additions & 0 deletions subsys/bluetooth/host/conn.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2390,6 +2390,11 @@ struct bt_conn *bt_conn_lookup_addr_br(const bt_addr_t *peer)
{
int i;

if (peer == NULL) {
LOG_DBG("Invalid peer address");
return NULL;
}

for (i = 0; i < ARRAY_SIZE(acl_conns); i++) {
struct bt_conn *conn = bt_conn_ref(&acl_conns[i]);

Expand Down
3 changes: 0 additions & 3 deletions subsys/bluetooth/host/conn_internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,9 +423,6 @@ void bt_sco_cleanup(struct bt_conn *sco_conn);
/* Look up an existing sco connection by BT address */
struct bt_conn *bt_conn_lookup_addr_sco(const bt_addr_t *peer);

/* Look up an existing connection by BT address */
struct bt_conn *bt_conn_lookup_addr_br(const bt_addr_t *peer);

void bt_conn_disconnect_all(uint8_t id);

/* Allocate new connection object */
Expand Down
Loading