drivers: ambiq: Correct peripheral instance calculation #87253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
aaronyegx,
RichardSWheatley,
swift-tk,
tbursztyka and
teburd
AlessandroLuo
force-pushed
the
ambiq-peripheral-inst-cal
branch
from
4ba5ad1 to
5046485
Compare
aaronyegx
previously approved these changes
Mar 18, 2025
swift-tk
reviewed
Mar 18, 2025
swift-tk
reviewed
Mar 18, 2025
AlessandroLuo
force-pushed
the
ambiq-peripheral-inst-cal
branch
3 times, most recently
from
5c74eee to
906338e
Compare
swift-tk
previously approved these changes
Mar 19, 2025
aaronyegx
previously approved these changes
Mar 19, 2025
RichardSWheatley
previously approved these changes
Mar 19, 2025
|
@AlessandroLuo this needs to be rebased - thx! |
I'm sure he will be happy to rebase but for future reference can you specify exactly why? |
AlessandroLuo
dismissed stale reviews from RichardSWheatley, aaronyegx, and swift-tk
via
c0a81ac
AlessandroLuo
force-pushed
the
ambiq-peripheral-inst-cal
branch
from
906338e to
c0a81ac
Compare
Done |
aaronyegx
previously approved these changes
Mar 21, 2025
swift-tk
previously approved these changes
Mar 24, 2025
This commit corrected ambiq peripheral instance calculations Signed-off-by: Hao Luo <hluo@ambiq.com>
AlessandroLuo
force-pushed
the
ambiq-peripheral-inst-cal
branch
from
c0a81ac to
cc09000
Compare
swift-tk
approved these changes
Mar 24, 2025
aaronyegx
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit corrected ambiq peripheral instance calculations