Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RW612: Add power init code for PM3 support #87594

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

RW612: Add power init code for PM3 support #87594

wants to merge 2 commits into from
+152 −8

Conversation

mmahadevan108
Copy link
Collaborator

  1. Add the power init code.
  2. Add code to support Low Power Mode support from the RTC 1HZ clock.

decsny
decsny reviewed Mar 24, 2025
View reviewed changes
@mmahadevan108 mmahadevan108 requested a review from decsny March 25, 2025 16:23
@dleach02
Copy link
Member

@mmahadevan108 need to address merge conflict

@mmahadevan108 mmahadevan108 mentioned this pull request Mar 28, 2025
Open
@mmahadevan108
boards: frdm_rw612: Add power init code for PM3 support
73680af 
1. Add the power init code.
2. Add code to support Low Power Mode support from the RTC
1HZ clock.

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
@mmahadevan108
boards: rd_rw612_bga: Add power init code for PM3 support
ba402d9 
1. Add the power init code.
2. Add code to support Low Power Mode support from the RTC
   1HZ clock.

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
@mmahadevan108
Copy link
Collaborator Author

@DeclanTraill @DerekSnell @dleach02 @EmilioCBen kindly review

DerekSnell
DerekSnell approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@DerekSnell DerekSnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mmahadevan108 ,
I have some comments for the documentation. But otherwise, this LGTM.

boards/nxp/frdm_rw612/doc/index.rst
@@ -57,7 +57,7 @@ Supported Features
| OS_TIMER | on-chip | os timer |
+-----------+------------+-----------------------------------+
| PM | on-chip | power management; uses SoC Power |
| | | Modes 1 and 2 |
| | | Modes 1, 2 and 3 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be aware, this table is removed in #87797, and will be auto-generated. You could add a new section in this doc detailing the power modes supported.

boards/nxp/frdm_rw612/doc/index.rst
RTC Sub-Second Counter
======================

To use the RTC sub-second counter which is clocked at a 32kHZ rate, you first need to make the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To use the RTC sub-second counter which is clocked at a 32kHZ rate, you first need to make the
To use the RTC sub-second counter which is clocked at a 32kHZ rate, make the

remove 2nd person "you" references

boards/nxp/frdm_rw612/doc/index.rst
Comment on lines +197 to +198
1. Move the short on SJ21 from 1 and 2 to short 2 and 3.
2. Move the short on SJ22 from 1 and 2 to short 2 and 3.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Move the short on SJ21 from 1 and 2 to short 2 and 3.
2. Move the short on SJ22 from 1 and 2 to short 2 and 3.
1. Move the jumper on SJ21 from pins 1-2 to 2-3.
2. Move the jumper on SJ22 from pins 1-2 to 2-3.

my preference

boards/nxp/frdm_rw612/doc/index.rst
1. Move the short on SJ21 from 1 and 2 to short 2 and 3.
2. Move the short on SJ22 from 1 and 2 to short 2 and 3.

After you make this change, the ENET will stop functioning on the board.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
After you make this change, the ENET will stop functioning on the board.
After this change, the ENET will stop functioning on the board.

boards/nxp/rd_rw612_bga/doc/index.rst
@@ -63,7 +63,7 @@ Supported Features
| OS_TIMER | on-chip | os timer |
+-----------+------------+-----------------------------------+
| PM | on-chip | power management; uses SoC Power |
| | | Modes 1 and 2 |
| | | Modes 1, 2 and 3 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be aware, this table is removed in #87797, and will be auto-generated. You could add a new section in this doc detailing the power modes supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DerekSnell DerekSnell DerekSnell approved these changes

@butok butok Awaiting requested review from butok

@dleach02 dleach02 Awaiting requested review from dleach02

@EmilioCBen EmilioCBen Awaiting requested review from EmilioCBen

@decsny decsny Awaiting requested review from decsny

At least 2 approving reviews are required to merge this pull request.

Assignees

@mmahadevan108 mmahadevan108

@dleach02 dleach02

Labels
platform: NXP NXP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mmahadevan108 @dleach02 @DerekSnell @decsny @zephyrbot