Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Trigger improvements #4836

Merged
merged 4 commits into from
Jun 4, 2024
Merged

[CI] Trigger improvements #4836

merged 4 commits into from
Jun 4, 2024

Conversation

pazone
Copy link
Contributor

@pazone pazone commented Jun 3, 2024

What does this PR do?

Draft PRs will not run integration tests. If you need to run them use /test extended trigger comment.
Introducing skip-ci and skip-it labels.
Makes buildkite pull request builds to ignore .ci and .github directories.
Also all *.md files
Made file patterns more strict by adding ^
Added CI cheatsheet to pull request template

Why is it important?

Integration tests were executed

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@pazone pazone added enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team backport-v8.14.0 Automated backport with mergify labels Jun 3, 2024
@pazone pazone requested a review from a team as a code owner June 3, 2024 11:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@pazone pazone changed the title [CI] Added .github and .ci directories to skip_ci_on_only_changed [CI] Trigger improvements Jun 3, 2024
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@pazone pazone merged commit 0b99ccb into main Jun 4, 2024
14 checks passed
@pazone pazone deleted the ci_int_test_github branch June 4, 2024 14:38
mergify bot pushed a commit that referenced this pull request Jun 4, 2024
* [CI] Added .github and .ci directories to skip_ci_on_only_changed

* [CI] Removed sonar-project.properties from ignored PR changesets

* [CI] skip labels and CI cheatsheet

* Added alternative triggers description

(cherry picked from commit 0b99ccb)

# Conflicts:
#	.buildkite/pull-requests.json
alexsapran added a commit to alexsapran/elastic-agent that referenced this pull request Jun 6, 2024
This commit partially reverts changes from elastic#4836.

Reson behind this is that the selected CI pipelines are defined as
required checks for PR and if the pipeline is not triggered then PR's
that change only files under the ignored list will not be able to get
merged.

Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co>
alexsapran added a commit that referenced this pull request Jun 6, 2024
This commit partially reverts changes from #4836.

Reson behind this is that the selected CI pipelines are defined as
required checks for PR and if the pipeline is not triggered then PR's
that change only files under the ignored list will not be able to get
merged.

Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.14.0 Automated backport with mergify enhancement New feature or request skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip integration tests for changes that do not modify Go source files
5 participants