Allow use of version qualifier for staging artifacts #4328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchila
added
Team:Elastic-Agent
|
This pull request does not have a backport label. Could you fix it @pchila? 🙏
|
|
|
mergify
bot
added
the
backport-8.x
pkoutsovasilis
approved these changes
Jan 16, 2025
swiatekm
approved these changes
Jan 16, 2025
dliappis
force-pushed
the
cleanup-package-script
branch
from
41c5424 to
48f3c4e
Compare
dliappis
force-pushed
the
cleanup-package-script
branch
from
48f3c4e to
4db0d39
Compare
dliappis
force-pushed
the
cleanup-package-script
branch
from
3d524b4 to
a05e7c2
Compare
dliappis
force-pushed
the
cleanup-package-script
branch
from
a05e7c2 to
e0545a3
Compare
dliappis
changed the title
michalpristas
approved these changes
Jan 17, 2025
dliappis
force-pushed
the
cleanup-package-script
branch
3 times, most recently
from
ea7b973 to
e5ac727
Compare
dliappis
force-pushed
the
cleanup-package-script
branch
from
e5ac727 to
a6f9934
Compare
Thanks, added a few comments in 6a3dd69, I hope they help clarify a little (also updated the PR description) |
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 17, 2025
This commits adds support for an optional $VERSION_QUALIFIER env var/build option in the packaging pipeline to allow building prerelease artifacts from staging. Closes: - #4325 - https://github.com/elastic/ingest-dev/issues/4859 --------- Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com> (cherry picked from commit 29c1d88)
pchila
added
backport-8.16
mergify bot
pushed a commit
that referenced
this pull request
Jan 17, 2025
This commits adds support for an optional $VERSION_QUALIFIER env var/build option in the packaging pipeline to allow building prerelease artifacts from staging. Closes: - #4325 - https://github.com/elastic/ingest-dev/issues/4859 --------- Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com> (cherry picked from commit 29c1d88)
mergify bot
pushed a commit
that referenced
this pull request
Jan 17, 2025
This commits adds support for an optional $VERSION_QUALIFIER env var/build option in the packaging pipeline to allow building prerelease artifacts from staging. Closes: - #4325 - https://github.com/elastic/ingest-dev/issues/4859 --------- Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com> (cherry picked from commit 29c1d88)
This was referenced Jan 17, 2025
pchila
added a commit
that referenced
this pull request
Jan 17, 2025
This commits adds support for an optional $VERSION_QUALIFIER env var/build option in the packaging pipeline to allow building prerelease artifacts from staging. Closes: - #4325 - https://github.com/elastic/ingest-dev/issues/4859 --------- Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com> (cherry picked from commit 29c1d88) Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
dliappis
added a commit
to dliappis/fleet-server
that referenced
this pull request
Jan 17, 2025
This commit is a follow-up to elastic#4328 and fixes a bug for main where staging main artifacts will be products for every merge commit, thus overriding manual builds using VERSION_QUALIFIER.
pchila
added a commit
that referenced
this pull request
Jan 17, 2025
This commits adds support for an optional $VERSION_QUALIFIER env var/build option in the packaging pipeline to allow building prerelease artifacts from staging. Closes: - #4325 - https://github.com/elastic/ingest-dev/issues/4859 --------- Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com> (cherry picked from commit 29c1d88) Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
pchila
added a commit
that referenced
this pull request
Jan 17, 2025
This commits adds support for an optional $VERSION_QUALIFIER env var/build option in the packaging pipeline to allow building prerelease artifacts from staging. Closes: - #4325 - https://github.com/elastic/ingest-dev/issues/4859 --------- Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com> (cherry picked from commit 29c1d88) Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
dliappis
added a commit
to dliappis/fleet-server
that referenced
this pull request
Jan 17, 2025
This commit fixes a bug in elastic#4328 running snapshot instead of staging for x86-64 and also ensures staging on main can be build when VERSION_QUALIFIER is set.
dliappis
added a commit
that referenced
this pull request
Jan 17, 2025
This commit fixes a bug in #4328 running snapshot instead of staging for x86-64 and also ensures staging on main can be build when VERSION_QUALIFIER is set.
This was referenced Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR solves?
This commits adds support for an optional $VERSION_QUALIFIER env var/build option in the packaging pipeline to allow building prerelease artifacts from staging.
How does this PR solve the problem?
DRA_BRANCHenv var and skip snapshot builds when VERSION_QUALIFIER is presentHow to test this PR locally
Using this PR and the pipeline https://buildkite.com/elastic/fleet-server-package-mbp with
pull/4328/mergeand options:results in a successful 9.0.0-alpha1 artifacts, example: https://buildkite.com/elastic/fleet-server-package-mbp/builds/1526
Also a test without VERSION_QUALIFIER https://buildkite.com/elastic/fleet-server-package-mbp/builds/1525 produces the expected artifacts (note that when branch is main, i.e. not when testing using this PR, and there is no version qualifier defined, the staging dra publish is skipped, per design).
Related issues
Closes: