[Linux] Add test logic to verify commissioning between Linux tv-casting-app and Linux tv-app. #33301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng-app and Linux tv-app.
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no,
ksperling-apple and
lazarkov
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #33301: Size comparison from 881676d to cd2ad23 Decreases (3 builds for cc32xx, stm32)
Full report (3 builds for cc32xx, stm32)
|
|
PR #33301: Size comparison from 881676d to 0ac57cc Increases (3 builds for bl702l, linux)
Decreases (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
|
PR #33301: Size comparison from 881676d to c43b59b Increases (3 builds for bl702l, linux)
Decreases (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
sharadb-amazon
approved these changes
May 3, 2024
yunhanw-google
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33300
Problem
There is no CI check to test that the commissioning between the Linux tv-casting-app and the Linux tv-app continues to work whenever a PR is created.
Solution Overview
Add testing logic to the
run_tv_casting_test.pyscript to verify that commissioning continues to work between the tv-casting-app and the tv-app.The output of the tv-casting-app and the tv-app will be parsed for strings of interest as they are received and the output will also be written to their corresponding log files.
The following has been added to the test script:
cast request {valid_discovered_commissioner_number}to the tv-casting-app subprocess once we find thecast request 0string in the tv-casting-app output. This is the indication from the tv-casting-app to the user that it is ready for the cast request to be initiated.device Name,vendor id, andproduct idnoted under theIdentification Declarationblock in the tv-casting-app output matches the corresponding values on the tv-app side.Via Shell Enter: controller ux ok|cancelstring. This will indicate that the user can approve the cast request by sendingcontroller ux okto the tv-app subprocess.Commissioning completed successfullyandPROMPT USER: commissioning successrespectively.Commissioning failedin the tv-casting-app output, we will print an error message, dump the logs to console, and exit on error.Testing
Tested the script locally by running
python3 ./scripts/tests/run_tv_casting_test.pyand observing the output. Also verified that the updated test script works as expected in the CI check.