Tv casting app stop connect when user navigates back before confirming passcode in commission #37278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yuenton-amazon
force-pushed
the
tv-casting-app-stop-connect-when-user-navigates-back-before-confirming-passcode-in-commission
branch
from
039b564 to
479a03b
Compare
...-casting-app/android/App/app/src/main/java/com/matter/casting/ConnectionExampleFragment.java
Outdated
Show resolved
Hide resolved
pgregorr-amazon
approved these changes
Jan 29, 2025
yuenton-amazon
force-pushed
the
tv-casting-app-stop-connect-when-user-navigates-back-before-confirming-passcode-in-commission
branch
from
479a03b to
5d31461
Compare
|
PR #37278: Size comparison from 9d99ef2 to 5d31461 Full report (3 builds for cc32xx, stm32)
|
...-casting-app/android/App/app/src/main/java/com/matter/casting/ConnectionExampleFragment.java
Outdated
Show resolved
Hide resolved
Updated Android & iOS tv-casting-app to send stopConnect command when user
exits UDC before confirming passcode
Changes
1. Added IsPendingPasscodeFromUser() to CastingPlayer. This function
will return true if we are still connecting and pending user action
for passcode
2. ConnectionExampleFragment.java onDestroy() calls stopConnect() if user
has not confirmed passcode
4. MCConnectionExampleView ConnectingView dissapear calls stopConnect()
if user has not confirmed passcode
Test
1. Manually verified UDC attempt is successful both Android iOS for following
1. Attempt UDC attempt (both commissionee & commissioner generated passcode)
2. Navigate back to discovery page
3. Start new UDC attempt (both commissionee & commissioner generated passcode)
2. Manually verified UDC attempt is successful both Android iOS for following. UDC will finish in the background.
1. Attempt UDC attempt (both commissionee & commissioner generated passcode)
2. Confirm passcode on TV app or casting app depending on who
generated passcode
3. Navigate back before commission fnishes.
3. Manual regression test following
* UDC attempt happy path (no navigate back) for both commissinee &
commissioner generated passcode
yuenton-amazon
force-pushed
the
tv-casting-app-stop-connect-when-user-navigates-back-before-confirming-passcode-in-commission
branch
from
5d31461 to
ac97dce
Compare
Updated native layer and iOS tv-casting-app to use native layer
ConnectionState instead of a pendingPasscode customer check.
Changes
* Expose native layer ConnectionState to iOS tv-casting-app
* Update iOS tv-casting-app to use ConnectionState to determine if we
should call stopConnect()
* Only call stopConnect() on navigate back from ConnectionExampleView
* Updated doc to indicate when a object method will free itself as a
side effect
Test
1. Manually verified UDC attempt is successful both Android iOS for following
1. Attempt UDC attempt (both commissionee & commissioner generated passcode)
2. Navigate back to discovery page
3. Start new UDC attempt (both commissionee & commissioner generated passcode)
2. Manually verified UDC attempt is successful both Android iOS for following. UDC will finish in the background.
1. Attempt UDC attempt (both commissionee & commissioner generated passcode)
2. Confirm passcode on TV app or casting app depending on who
generated passcode
3. Navigate back before commission fnishes.
3. Manual regression test following
* UDC attempt happy path (no navigate back) for both commissinee &
commissioner generated passcode
Updated JNI and Android tv-casting-app to use native layer
ConnectionState instead of a pendingPasscode customer check.
Changes
* Expose native layer ConnectionState to Android tv-casting-app
* Update Android tv-casting-app to use ConnectionState to determine if we
should call stopConnect()
* Only call stopConnect() on navigate back from
ConnectionExampleFragmnet
Test
1. Manually verified UDC attempt is successful both Android iOS for following
1. Attempt UDC attempt (both commissionee & commissioner generated passcode)
2. Navigate back to discovery page
3. Start new UDC attempt (both commissionee & commissioner generated passcode)
2. Manually verified UDC attempt is successful both Android iOS for following. UDC will finish in the background.
1. Attempt UDC attempt (both commissionee & commissioner generated passcode)
2. Confirm passcode on TV app or casting app depending on who
generated passcode
3. Navigate back before commission fnishes.
3. Manual regression test following
* UDC attempt happy path (no navigate back) for both commissinee &
commissioner generated passcode
yuenton-amazon
force-pushed
the
tv-casting-app-stop-connect-when-user-navigates-back-before-confirming-passcode-in-commission
branch
from
ac97dce to
208e4d6
Compare
Applied restyle formatting
Fix restyle CI error
|
PR #37278: Size comparison from 74d91fd to e1c6340 Full report (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
sharadb-amazon
approved these changes
Mar 3, 2025
examples/tv-casting-app/android/App/app/src/main/jni/cpp/core/MatterCastingPlayer-JNI.cpp
Outdated
Show resolved
Hide resolved
examples/tv-casting-app/android/App/app/src/main/jni/cpp/core/MatterCastingPlayer-JNI.cpp
Show resolved
Hide resolved
Updated JNI and Android tv-casting-app to use CharToStringUTF
util function to create jstring and handle NULL JNIEnv interface
Changes
* JNI to use CharToStringUTF util function to create jstring
* Updated documentation for new JNI functions
Test
1. Manually verified UDC attempt is successful both Android iOS for following
1. Attempt UDC attempt (both commissionee & commissioner generated passcode)
2. Navigate back to discovery page
3. Start new UDC attempt (both commissionee & commissioner generated passcode)
2. Manually verified UDC attempt is successful both Android iOS for following. UDC will finish in the background.
1. Attempt UDC attempt (both commissionee & commissioner generated passcode)
2. Confirm passcode on TV app or casting app depending on who
generated passcode
3. Navigate back before commission fnishes.
3. Manual regression test following
* UDC attempt happy path (no navigate back) for both commissinee &
commissioner generated passcode
auto-merge was automatically disabled
March 4, 2025 01:16
Head branch was pushed to by a user without write access
Updated JNI and Android tv-casting-app to use CharToStringUTF
util function to create jstring and handle NULL JNIEnv interface
Changes
* JNI to use CharToStringUTF util function to create jstring for all
ConnectionState and not just errors
Test
1. Manually verified UDC attempt is successful both Android iOS for following
1. Attempt UDC attempt (both commissionee & commissioner generated passcode)
2. Navigate back to discovery page
3. Start new UDC attempt (both commissionee & commissioner generated passcode)
2. Manually verified UDC attempt is successful both Android iOS for following. UDC will finish in the background.
1. Attempt UDC attempt (both commissionee & commissioner generated passcode)
2. Confirm passcode on TV app or casting app depending on who
generated passcode
3. Navigate back before commission fnishes.
3. Manual regression test following
* UDC attempt happy path (no navigate back) for both commissinee &
commissioner generated passcode
|
PR #37278: Size comparison from 74d91fd to 883b69a Full report (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yunhanw-google
approved these changes
Mar 4, 2025
gmarcosb
pushed a commit
to gmarcosb/connectedhomeip
that referenced
this pull request
Mar 4, 2025
…g passcode in commission (project-chip#37278) * [Amazon] StopConnect for UDC in Android tv-casting-app Updated Android & iOS tv-casting-app to send stopConnect command when user exits UDC before confirming passcode Changes 1. Added IsPendingPasscodeFromUser() to CastingPlayer. This function will return true if we are still connecting and pending user action for passcode 2. ConnectionExampleFragment.java onDestroy() calls stopConnect() if user has not confirmed passcode 4. MCConnectionExampleView ConnectingView dissapear calls stopConnect() if user has not confirmed passcode Test 1. Manually verified UDC attempt is successful both Android iOS for following 1. Attempt UDC attempt (both commissionee & commissioner generated passcode) 2. Navigate back to discovery page 3. Start new UDC attempt (both commissionee & commissioner generated passcode) 2. Manually verified UDC attempt is successful both Android iOS for following. UDC will finish in the background. 1. Attempt UDC attempt (both commissionee & commissioner generated passcode) 2. Confirm passcode on TV app or casting app depending on who generated passcode 3. Navigate back before commission fnishes. 3. Manual regression test following * UDC attempt happy path (no navigate back) for both commissinee & commissioner generated passcode * [Amazon] StopConnect for UDC in Android tv-casting-app Updated native layer and iOS tv-casting-app to use native layer ConnectionState instead of a pendingPasscode customer check. Changes * Expose native layer ConnectionState to iOS tv-casting-app * Update iOS tv-casting-app to use ConnectionState to determine if we should call stopConnect() * Only call stopConnect() on navigate back from ConnectionExampleView * Updated doc to indicate when a object method will free itself as a side effect Test 1. Manually verified UDC attempt is successful both Android iOS for following 1. Attempt UDC attempt (both commissionee & commissioner generated passcode) 2. Navigate back to discovery page 3. Start new UDC attempt (both commissionee & commissioner generated passcode) 2. Manually verified UDC attempt is successful both Android iOS for following. UDC will finish in the background. 1. Attempt UDC attempt (both commissionee & commissioner generated passcode) 2. Confirm passcode on TV app or casting app depending on who generated passcode 3. Navigate back before commission fnishes. 3. Manual regression test following * UDC attempt happy path (no navigate back) for both commissinee & commissioner generated passcode * [Amazon] StopConnect for UDC in Android tv-casting-app Updated JNI and Android tv-casting-app to use native layer ConnectionState instead of a pendingPasscode customer check. Changes * Expose native layer ConnectionState to Android tv-casting-app * Update Android tv-casting-app to use ConnectionState to determine if we should call stopConnect() * Only call stopConnect() on navigate back from ConnectionExampleFragmnet Test 1. Manually verified UDC attempt is successful both Android iOS for following 1. Attempt UDC attempt (both commissionee & commissioner generated passcode) 2. Navigate back to discovery page 3. Start new UDC attempt (both commissionee & commissioner generated passcode) 2. Manually verified UDC attempt is successful both Android iOS for following. UDC will finish in the background. 1. Attempt UDC attempt (both commissionee & commissioner generated passcode) 2. Confirm passcode on TV app or casting app depending on who generated passcode 3. Navigate back before commission fnishes. 3. Manual regression test following * UDC attempt happy path (no navigate back) for both commissinee & commissioner generated passcode * [Amazon] StopConnect for UDC in Android tv-casting-app Applied restyle formatting * [Amazon] StopConnect for UDC in Android tv-casting-app Fix restyle CI error * [Amazon] StopConnect for UDC in Android tv-casting-app Updated JNI and Android tv-casting-app to use CharToStringUTF util function to create jstring and handle NULL JNIEnv interface Changes * JNI to use CharToStringUTF util function to create jstring * Updated documentation for new JNI functions Test 1. Manually verified UDC attempt is successful both Android iOS for following 1. Attempt UDC attempt (both commissionee & commissioner generated passcode) 2. Navigate back to discovery page 3. Start new UDC attempt (both commissionee & commissioner generated passcode) 2. Manually verified UDC attempt is successful both Android iOS for following. UDC will finish in the background. 1. Attempt UDC attempt (both commissionee & commissioner generated passcode) 2. Confirm passcode on TV app or casting app depending on who generated passcode 3. Navigate back before commission fnishes. 3. Manual regression test following * UDC attempt happy path (no navigate back) for both commissinee & commissioner generated passcode * [Amazon] StopConnect for UDC in Android tv-casting-app Updated JNI and Android tv-casting-app to use CharToStringUTF util function to create jstring and handle NULL JNIEnv interface Changes * JNI to use CharToStringUTF util function to create jstring for all ConnectionState and not just errors Test 1. Manually verified UDC attempt is successful both Android iOS for following 1. Attempt UDC attempt (both commissionee & commissioner generated passcode) 2. Navigate back to discovery page 3. Start new UDC attempt (both commissionee & commissioner generated passcode) 2. Manually verified UDC attempt is successful both Android iOS for following. UDC will finish in the background. 1. Attempt UDC attempt (both commissionee & commissioner generated passcode) 2. Confirm passcode on TV app or casting app depending on who generated passcode 3. Navigate back before commission fnishes. 3. Manual regression test following * UDC attempt happy path (no navigate back) for both commissinee & commissioner generated passcode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Android tv-casting-app to send stopConnect command when user exits UDC before confirming passcode
Changes
will return true if we are still connecting and pending user action
for passcode
has not confirmed passcode
if user has not confirmed passcode
Testing
Manually verified UDC attempt is successful both Android iOS for following
Manually verified UDC attempt is successful both Android iOS for following. UDC will finish in the background.
generated passcode
Manual regression test following
commissioner generated passcode