Check if a duplicated provider is present before loading into RAM #37643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
silabs-olivierb
changed the title
mkardous-silabs
approved these changes
Feb 19, 2025
selissia
approved these changes
Feb 19, 2025
|
PR #37643: Size comparison from 33aec35 to cd57984 Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
silabs-olivierb
force-pushed
the
silabs/ota_requestor
branch
from
e8582d1 to
06a3d25
Compare
bzbarsky-apple
approved these changes
Feb 19, 2025
|
PR #37643: Size comparison from 8464e5f to 8ebe07d Full report (59 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, nxp, psoc6, qpg, stm32, tizen)
|
silabs-olivierb
force-pushed
the
silabs/ota_requestor
branch
from
8ebe07d to
cb101e7
Compare
|
PR #37643: Size comparison from a5971fa to dd067bf Full report (17 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, qpg, stm32, tizen)
|
|
PR #37643: Size comparison from a5971fa to d6371da Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37643: Size comparison from 5398152 to c0f5bcc Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
silabs-olivierb
force-pushed
the
silabs/ota_requestor
branch
from
c0f5bcc to
9cf01e5
Compare
|
PR #37643: Size comparison from 1543d47 to 9cf01e5 Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37643: Size comparison from 0d6b2fb to 1989bab Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
…st as a private member
silabs-olivierb
force-pushed
the
silabs/ota_requestor
branch
from
1989bab to
6aa5845
Compare
|
PR #37643: Size comparison from 19ebee7 to 6aa5845 Full report (3 builds for cc32xx, stm32)
|
|
PR #37643: Size comparison from 64ae4d8 to 1fde485 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
gmarcosb
pushed a commit
to gmarcosb/connectedhomeip
that referenced
this pull request
Mar 4, 2025
…oject-chip#37643) * [Silabs] Check if a duplicated provider is present before loading it to RAM * [Silabs] Added change requested by bzbarsky-apple * Restyled by clang-format * Fixed codereview request * Fixed unit test issues * Restyled by clang-format * Make ProviderAlreadyInList public instead of private * Update src/app/clusters/ota-requestor/DefaultOTARequestorStorage.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Should return false if the check is made on an empty list * Fixed unit test, removed GetListSize and put back ProviderAlreadyInList as a private member * Fixed unit test * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is happening is that every time IP connectivity is established (i.e. when the device (re)joins the fabric) the InitOTARequestorHandler callback is invoked which reads the configured providers from NVM into a RAM. And we don't check whether the entry is already present in the RAM.
Testing
Some unit testing has been added, to test the CheckDuplicateProvider function. Some tests has been made manually with a BRD4186C with multiple ecosystems.