Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement/261 complete commercial endpoint functionality #283

Merged
merged 13 commits into from
Jan 7, 2025
Merged

Enhancement/261 complete commercial endpoint functionality #283

merged 13 commits into from
Jan 7, 2025

Conversation

XxILUSHAxX
Copy link
Contributor

Commercial endpoint implemenation

XxILUSHAxX and others added 5 commits December 16, 2024 12:35
@XxILUSHAxX XxILUSHAxX marked this pull request as ready for review December 16, 2024 15:58
@astanik astanik added the enhancement New feature or request label Dec 17, 2024
@astanik astanik linked an issue Dec 17, 2024 that may be closed by this pull request
Complete commercial endpoint functionality #261
Closed
@F4c3hugg3r
Copy link
Contributor

I'd review this pull request in the upcoming days

@astanik astanik requested a review from F4c3hugg3r December 18, 2024 08:19
@XxILUSHAxX XxILUSHAxX marked this pull request as draft December 18, 2024 15:00
@XxILUSHAxX XxILUSHAxX mentioned this pull request Dec 18, 2024
Merged
F4c3hugg3r
F4c3hugg3r suggested changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@F4c3hugg3r F4c3hugg3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Die meisten Anforderungen des dazugehörigen Issues wurden umgesetzt. Die CRUD Operationen sind vorhanden und überwiegend sehr gut implementiert, allerdings muss der Code fehlerlos kompilierbar werden und die angemerkten Änderungen der Logik bezogen auf das rent Attribut müssen geändert werden. Die im Issue genannte Testabdeckung ist auch nicht vorhanden und sollte ergänzt werden. Für genauere Infos bezüglich der zu machenden Änderungen bitte die Kommentare anschauen.

@astanik astanik mentioned this pull request Jan 6, 2025
Merged
@XxILUSHAxX
solve review comments without the tests
a4d313d
@XxILUSHAxX
Merge branch 'enhancement/261-complete-commercial-endpoint-functional…
6e9deb0 
…ity' of github.com:XxILUSHAxX/remsfal-backend into enhancement/261-complete-commercial-endpoint-functionality
@XxILUSHAxX
Controller+Resource+Repository Tests
687cc73
@XxILUSHAxX
Merge branch 'refs/heads/main' into enhancement/261-complete-commerci…
b59318a 
…al-endpoint-functionality

# Conflicts:
#	remsfal-service/src/main/java/de/remsfal/service/control/BuildingController.java
#	remsfal-service/src/test/java/de/remsfal/service/control/BuildingControllerTest.java
@XxILUSHAxX
delete double data
1b6fde4
@XxILUSHAxX XxILUSHAxX marked this pull request as ready for review January 6, 2025 18:38
@XxILUSHAxX
Copy link
Contributor Author

Hello @F4c3hugg3r, i thank you for your constructive feedback, i definetely had some issues which needed to get fixed and i learned as well new things. I took the necessary changes, completed the test classes for the classes used for the Commercial Endpoint and now everything should be perfect. Please take a look at my pull request and let me know if there are any things which i need to repolish.

F4c3hugg3r
F4c3hugg3r approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@F4c3hugg3r F4c3hugg3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sieht jetzt alles gut aus.

astanik
astanik approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@astanik astanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed duplicate dependencies and unused field

@astanik astanik merged commit 6b14afb into remsfal:main Jan 7, 2025
8 checks passed
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
91.4% Coverage on New Code
2.6% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astanik astanik astanik approved these changes

@F4c3hugg3r F4c3hugg3r F4c3hugg3r approved these changes

Assignees

@XxILUSHAxX XxILUSHAxX

Labels
enhancement New feature or request ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Complete commercial endpoint functionality
3 participants
@XxILUSHAxX @F4c3hugg3r @astanik