Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix call didn't revert at a lower depth than cheatcode call depth forge error in EVM tests #591

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

nvsriram
Copy link
Collaborator

With Foundry v1 release, some forge tests have been failing with this error.
This PR fixes this by adding /// forge-config: default.allow_internal_expect_revert = true above the test function.

See https://book.getfoundry.sh/cheatcodes/expect-revert#description for reference:

Selectively by using an inline configuration entry where it is DEEMED SAFE:
Add /// forge-config: default.allow_internal_expect_revert = true above the test function.

@nvsriram nvsriram requested review from djb15 and nonergodic February 21, 2025 20:32
Copy link
Contributor

@kcsongor kcsongor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@nvsriram nvsriram merged commit 2d402b9 into main Feb 22, 2025
9 checks passed
@nvsriram nvsriram deleted the ci/fix-foundry-v1-test-issue branch February 22, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants